-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set_climatisation #450 #492
base: master
Are you sure you want to change the base?
Conversation
set_climatisation #450
for more information, see https://pre-commit.ci
i was testing the start_climate_control with my Q4
|
Q4 data structure is different than all the older vehicles, and as you know, the EU is different than NA region endpoints. I dont know if the Q4 data structure is going to be the new standard or if only for electric vehicles or some other subset of vehicles. A while back i was working on some logic to use the correct logic based on the vehicle, or even having the user select an option under integration options. Your Q4 uses Celsius in the new data structure. Legacy data structure used 'deca-kelvin'. Why they used that in the past, i have no idea. My time is so limited these days, I'm really not sure I'll have time to work on this until the new year, unfortunately. Making it work universally and smart enough to do it automatically is the real challenge. I was also working on integration options that the user would select to try different data structures or endpoints. Ultimately that may be the best path forward, but again, last time i worked on it, they changed everything again so I lost the progress. Happy to answer any questions you have if any others. |
ok, that makes sence with the temparature |
set_climatisation #450
#450 (comment)