Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule, 318-FEE #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new rule, 318-FEE #77

wants to merge 2 commits into from

Conversation

audiodude
Copy link
Owner

I've noticed that scores are not being updated particularly consistently, and decided to add some incentive for players to update each other's scores.

Also please note in advance that the rules of ACRONYM do not require that that words constituting the acronym make any kind of sense.

@datagrok
Copy link
Collaborator

datagrok commented Aug 6, 2017

This is brilliant and much needed and I love the title, I vote 👍

@piersb
Copy link
Collaborator

piersb commented Aug 6, 2017 via email

@sashahart
Copy link
Contributor

👎

@audiodude
Copy link
Owner Author

Sorry I forgot how to nomic.

It seems by the new TIMER that this is older than 48 hours and the majority of players who voted voted in favor. Therefore it is "acceptable" and can be merged?

The rules of FAST still seem to imply that someone has to tally the vote (which I believe I am doing with this comment) and someone else has to merge the PR.

@datagrok
Copy link
Collaborator

datagrok commented Aug 8, 2017

@audiodude yes, but not until your turn. If a sufficient number of 48-hour periods has elapsed since the last person who took a turn (I haven't checked), you can resolve all the turns in between theirs and yours yourself by doing merges (or penalties) for the absentee players, and then you can take your turn, merging your own.

Or, at least, that was the intent of my changes, I'm not sure I accomplished it with my prose. I'm still working on expressing that in a simpler way.

@audiodude
Copy link
Owner Author

audiodude commented Aug 8, 2017

$ python tools/timer 67
The time is now Aug 08, 11:23AM.

    datagrok opened PR #67, beginning their turn, at Jul 27, 05:31PM.
    * Discussion is closed. Voting began at Jul 28, 05:31PM.
    * Voting concluded and the PR was closed.
    datagrok's turn ended Jul 29, 11:54PM.
     bigjust forfeited their turn at  Jul 31, 11:54PM.
   sashahart forfeited their turn at  Aug 02, 11:54PM.
   audiodude forfeited their turn at  Aug 04, 11:54PM.
    selfsame forfeited their turn at  Aug 06, 11:54PM.
 @fonorobert must begin their turn between then and Aug 08, 11:54PM. (13h from now).
     @piersb must begin their turn between then and Aug 10, 11:54PM. (2d + 13h from now).

I would have forfeited my turn on Aug 04 at 11:54 PM, but:

$ python tools/timer 77
The time is now Aug 08, 11:23AM.

   audiodude opened PR #77, beginning their turn, at Aug 04, 05:40PM.
    * Discussion is closed. Voting began at Aug 05, 05:40PM.
    * Voting concluded and the PR was closed.
   audiodude's turn ended Aug 06, 05:40PM.
   @selfsame must begin their turn between then and Aug 08, 05:40PM. (6h from now).

@audiodude
Copy link
Owner Author

Sorry, the last turn was @bigjust. So I think it is currently my turn? Or my turn ends automatically once this is merged by any player?

$ python tools/timer 70
The time is now Aug 08, 11:29AM.

     bigjust opened PR #70, beginning their turn, at Jul 31, 06:18AM.
    * Discussion is closed. Voting began at Aug 01, 06:18AM.
    * Voting concluded and the PR was closed.
     bigjust's turn ended Aug 04, 05:31PM.
   sashahart forfeited their turn at  Aug 06, 05:31PM.
  @audiodude must begin their turn between then and Aug 08, 05:31PM. (6h from now).
   @selfsame must begin their turn between then and Aug 10, 05:31PM. (2d + 6h from now).
 @fonorobert must begin their turn between then and Aug 12, 05:31PM. (4d + 6h from now).
     @piersb must begin their turn between then and Aug 14, 05:31PM. (6d + 6h from now).
  @cardboard must begin their turn between then and Aug 16, 05:31PM. (8d + 6h from now).
  @william42 must begin their turn between then and Aug 18, 05:31PM. (10d + 6h from now).
    @kgrover must begin their turn between then and Aug 20, 05:31PM. (12d + 6h from now).
   @datagrok must begin their turn between then and Aug 22, 05:31PM. (14d + 6h from now).
    @bigjust must begin their turn between then and Aug 24, 05:31PM. (16d + 6h from now).
  @sashahart must begin their turn between then and Aug 26, 05:31PM. (18d + 6h from now).

@datagrok
Copy link
Collaborator

datagrok commented Aug 8, 2017

@audiodude

  • the timer script definitely needs to be updated for the new rule but i suppose it's still good enough for counting off 48-hour periods
  • yes, (i think) we are currently within the 48-hour window in which you may propose a new rule if you wish but
  • since this proposal is both acceptable and has existed long enough to give everyone who wants to a chance to comment/vote, anybody can now merge it, thus ending your turn
  • if you don't act within your 48-hour window you can still take your turn as normal as long as nobody else gets around to resolving it for you
  • there should be new language in the TIMER rule explicitly allowing you to merge your own commit and taking precedence over FAST

@audiodude
Copy link
Owner Author

Any player may accept (merge) The Player's first acceptable proposal.

So it sounds like I can already merge my own?

@datagrok
Copy link
Collaborator

datagrok commented Aug 8, 2017

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants