-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline/sererity 20230925 #936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* impl private name tag * add logic CRUD name tag with encrypt/decrypt data * add where by user_id * add note & change length name_tag * add module encryption * add provider * done logic * remove rem cmt for test * Update src/components/private-name-tag/services/private-name-tag.service.ts Co-authored-by: Duc Nguyen <[email protected]> * remove migrate unused * add provider and format code --------- Co-authored-by: Duc Nguyen <[email protected]>
* add is_favorite column * add favorite and test ok * Update src/components/private-name-tag/dtos/get-private-name-tag-result.dto.ts Co-authored-by: hoangtv49 <[email protected]> * resolve comment & add throw err * remove redundant * add validate whitelist dto update private name tag * resolve comment & fix encrypt when update * resolve comment & fix encrypt when update --------- Co-authored-by: hoangtv49 <[email protected]>
* fix duplicate private name tag in an account * fix comment
* fix error can't edit current entity * add keyword to get private name tag API * add search address, name tag exactly
nthduc95
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
duonghb53
added a commit
that referenced
this pull request
Oct 2, 2023
nthduc95
added a commit
that referenced
this pull request
Oct 3, 2023
* Baseline/sererity 20230925 (#936) * [[Private Name Tag] Limited - Squash and merge to develop (#938) (#939) * add check limited private name tag * fix litmit private name tag & remove api unused * change message limit from env * Baseline/serenity 20230926 (#937) [Public-name-tag][CW20] Enhance admin nametag * fix comment --------- Co-authored-by: Duc Nguyen <[email protected]>
duonghb53
added a commit
that referenced
this pull request
Oct 9, 2023
* Baseline/sererity 20230925 (#936) * [[Private Name Tag] Limited - Squash and merge to develop (#938) (#939) * add check limited private name tag * fix litmit private name tag & remove api unused * change message limit from env * Baseline/serenity 20230926 (#937) [Public-name-tag][CW20] Enhance admin nametag * fix comment --------- Co-authored-by: Duc Nguyen <[email protected]>
duonghb53
added a commit
that referenced
this pull request
Oct 9, 2023
* Baseline/sererity 20230925 (#936) * [[Private Name Tag] Limited - Squash and merge to develop (#938) (#939) * add check limited private name tag * fix litmit private name tag & remove api unused * change message limit from env * Baseline/serenity 20230926 (#937) [Public-name-tag][CW20] Enhance admin nametag * fix comment --------- Co-authored-by: Duc Nguyen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl Private Name Tag