Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/private name tag add limit #938

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

duonghb53
Copy link
Contributor

  1. Add limited private in env file. default 10
  2. Remove API unused with nextKey

@duonghb53 duonghb53 self-assigned this Sep 27, 2023
Copy link
Collaborator

@nthduc95 nthduc95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duonghb53 duonghb53 merged commit 684c7cf into develop Sep 27, 2023
2 checks passed
duonghb53 added a commit that referenced this pull request Sep 27, 2023
* add check limited private name tag

* fix litmit private name tag & remove api unused

* change message limit from env
duonghb53 added a commit that referenced this pull request Sep 27, 2023
* add check limited private name tag

* fix litmit private name tag & remove api unused

* change message limit from env
duonghb53 added a commit that referenced this pull request Oct 2, 2023
* add check limited private name tag

* fix litmit private name tag & remove api unused

* change message limit from env
nthduc95 added a commit that referenced this pull request Oct 3, 2023
* Baseline/sererity 20230925 (#936)

* [[Private Name Tag] Limited - Squash and merge to develop (#938) (#939)

* add check limited private name tag

* fix litmit private name tag & remove api unused

* change message limit from env

* Baseline/serenity 20230926 (#937)

[Public-name-tag][CW20] Enhance admin nametag

* fix comment

---------

Co-authored-by: Duc Nguyen <[email protected]>
duonghb53 added a commit that referenced this pull request Oct 9, 2023
* Baseline/sererity 20230925 (#936)

* [[Private Name Tag] Limited - Squash and merge to develop (#938) (#939)

* add check limited private name tag

* fix litmit private name tag & remove api unused

* change message limit from env

* Baseline/serenity 20230926 (#937)

[Public-name-tag][CW20] Enhance admin nametag

* fix comment

---------

Co-authored-by: Duc Nguyen <[email protected]>
duonghb53 added a commit that referenced this pull request Oct 9, 2023
* Baseline/sererity 20230925 (#936)

* [[Private Name Tag] Limited - Squash and merge to develop (#938) (#939)

* add check limited private name tag

* fix litmit private name tag & remove api unused

* change message limit from env

* Baseline/serenity 20230926 (#937)

[Public-name-tag][CW20] Enhance admin nametag

* fix comment

---------

Co-authored-by: Duc Nguyen <[email protected]>
@duonghb53 duonghb53 mentioned this pull request Oct 9, 2023
@nhphuc2411 nhphuc2411 deleted the fix/private-name-tag-add-limit branch January 31, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants