feat: erc20 contract no action #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamphong9981
commented
Sep 24, 2024
| table.jsonb('no_action').defaultTo('{}'); | ||
| }); | ||
| await knex.raw(`set statement_timeout to 0`); | ||
| const [totalTransfer, totalApproval, totalDeposit, totalWithdrawal] = |
There was a problem hiding this comment.
@peara Đoạn này đáng ra em nên group by theo cả action thì chỉ cần 1 query, em vừa để ý :)) nhưng mà đoạn sau xử lý trong code cũng phức tạp, mà migration cũng chạy 1 lần em thấy story chạy đc rồi ạ
peara
reviewed
Sep 24, 2024
src/models/erc20_contract.ts
Outdated
| @@ -27,6 +27,8 @@ export class Erc20Contract extends BaseModel { | |||
|
|
|||
| last_updated_height!: number; | |||
|
|
|||
| no_action!: any; | |||
There was a problem hiding this comment.
cho thành total_actions đi, no_action nghe như ko hay lắm
peara
reviewed
Sep 24, 2024
| @@ -86,6 +86,12 @@ export class Erc20Handler { | |||
| ) { | |||
| this.handlerErc20Transfer(erc20Activity); | |||
| } | |||
| this.erc20Contracts[erc20Activity.erc20_contract_address].no_action[ | |||
| erc20Activity.action | |||
There was a problem hiding this comment.
sao lại có cái action này ở trong nhỉ? ko phải là đếm tổng à?
ở trên aurascan ghi là |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add no_action column to erc20_contract table
