chore(all): prepare release 0.3.4

aurelia · Feb 6, 2015 · 478c969 · 478c969
1 parent 854930a
commit 478c969
Show file tree

Hide file tree

Showing 11 changed files with 134 additions and 94 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "aurelia-binding",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "A modern databinding library for JavaScript and HTML.",
   "license": "MIT",
   "keywords": [

diff --git a/dist/amd/observer-locator.js b/dist/amd/observer-locator.js
@@ -59,25 +59,29 @@ define(["exports", "aurelia-task-queue", "./array-observation", "./event-manager
   function createObserversLookup(obj) {
     var value = {};
 
-    Object.defineProperty(obj, "__observers__", {
-      enumerable: false,
-      configurable: false,
-      writable: false,
-      value: value
-    });
+    try {
+      Object.defineProperty(obj, "__observers__", {
+        enumerable: false,
+        configurable: false,
+        writable: false,
+        value: value
+      });
+    } catch (_) {}
 
     return value;
   }
 
   function createObserverLookup(obj) {
     var value = new OoObjectObserver(obj);
 
-    Object.defineProperty(obj, "__observer__", {
-      enumerable: false,
-      configurable: false,
-      writable: false,
-      value: value
-    });
+    try {
+      Object.defineProperty(obj, "__observer__", {
+        enumerable: false,
+        configurable: false,
+        writable: false,
+        value: value
+      });
+    } catch (_) {}
 
     return value;
   }

diff --git a/dist/amd/property-observation.js b/dist/amd/property-observation.js
@@ -96,12 +96,14 @@ define(["exports"], function (exports) {
           this.setValue = this.setterValue;
           this.getValue = this.getterValue;
 
-          Object.defineProperty(this.obj, this.propertyName, {
-            configurable: true,
-            enumerable: true,
-            get: this.getValue.bind(this),
-            set: this.setValue.bind(this)
-          });
+          try {
+            Object.defineProperty(this.obj, this.propertyName, {
+              configurable: true,
+              enumerable: true,
+              get: this.getValue.bind(this),
+              set: this.setValue.bind(this)
+            });
+          } catch (_) {}
         },
         writable: true,
         configurable: true
@@ -125,9 +127,11 @@ define(["exports"], function (exports) {
 
           if (!this.observing) {
             this.observing = true;
-            Object.observe(this.obj, function (changes) {
-              return _this.handleChanges(changes);
-            }, ["update", "add"]);
+            try {
+              Object.observe(this.obj, function (changes) {
+                return _this.handleChanges(changes);
+              }, ["update", "add"]);
+            } catch (_) {}
           }
 
           return function () {

diff --git a/dist/commonjs/observer-locator.js b/dist/commonjs/observer-locator.js
@@ -62,25 +62,29 @@ var hasObjectObserve = (function detectObjectObserve() {
 function createObserversLookup(obj) {
   var value = {};
 
-  Object.defineProperty(obj, "__observers__", {
-    enumerable: false,
-    configurable: false,
-    writable: false,
-    value: value
-  });
+  try {
+    Object.defineProperty(obj, "__observers__", {
+      enumerable: false,
+      configurable: false,
+      writable: false,
+      value: value
+    });
+  } catch (_) {}
 
   return value;
 }
 
 function createObserverLookup(obj) {
   var value = new OoObjectObserver(obj);
 
-  Object.defineProperty(obj, "__observer__", {
-    enumerable: false,
-    configurable: false,
-    writable: false,
-    value: value
-  });
+  try {
+    Object.defineProperty(obj, "__observer__", {
+      enumerable: false,
+      configurable: false,
+      writable: false,
+      value: value
+    });
+  } catch (_) {}
 
   return value;
 }

diff --git a/dist/commonjs/property-observation.js b/dist/commonjs/property-observation.js
@@ -95,12 +95,14 @@ var SetterObserver = exports.SetterObserver = (function () {
         this.setValue = this.setterValue;
         this.getValue = this.getterValue;
 
-        Object.defineProperty(this.obj, this.propertyName, {
-          configurable: true,
-          enumerable: true,
-          get: this.getValue.bind(this),
-          set: this.setValue.bind(this)
-        });
+        try {
+          Object.defineProperty(this.obj, this.propertyName, {
+            configurable: true,
+            enumerable: true,
+            get: this.getValue.bind(this),
+            set: this.setValue.bind(this)
+          });
+        } catch (_) {}
       },
       writable: true,
       configurable: true
@@ -124,9 +126,11 @@ var OoObjectObserver = exports.OoObjectObserver = (function () {
 
         if (!this.observing) {
           this.observing = true;
-          Object.observe(this.obj, function (changes) {
-            return _this.handleChanges(changes);
-          }, ["update", "add"]);
+          try {
+            Object.observe(this.obj, function (changes) {
+              return _this.handleChanges(changes);
+            }, ["update", "add"]);
+          } catch (_) {}
         }
 
         return function () {

diff --git a/dist/es6/observer-locator.js b/dist/es6/observer-locator.js
@@ -3,9 +3,9 @@ import {getArrayObserver} from './array-observation';
 import {EventManager} from './event-manager';
 import {DirtyChecker, DirtyCheckProperty} from './dirty-checking';
 import {
-  SetterObserver, 
-  OoObjectObserver, 
-  OoPropertyObserver, 
+  SetterObserver,
+  OoObjectObserver,
+  OoPropertyObserver,
   ElementObserver
 } from './property-observation';
 import {All} from 'aurelia-dependency-injection';
@@ -57,25 +57,29 @@ var hasObjectObserve = (function detectObjectObserve() {
 function createObserversLookup(obj) {
   var value = {};
 
-  Object.defineProperty(obj, "__observers__", {
-    enumerable: false,
-    configurable: false,
-    writable: false,
-    value: value
-  });
+  try{
+    Object.defineProperty(obj, "__observers__", {
+      enumerable: false,
+      configurable: false,
+      writable: false,
+      value: value
+    });
+  }catch(_){}
 
   return value;
 }
 
 function createObserverLookup(obj) {
   var value = new OoObjectObserver(obj);
 
-  Object.defineProperty(obj, "__observer__", {
-    enumerable: false,
-    configurable: false,
-    writable: false,
-    value: value
-  });
+  try{
+    Object.defineProperty(obj, "__observer__", {
+      enumerable: false,
+      configurable: false,
+      writable: false,
+      value: value
+    });
+  }catch(_){}
 
   return value;
 }
@@ -101,7 +105,7 @@ export class ObserverLocator {
     }
 
     return observersLookup[propertyName] = this.createPropertyObserver(
-      obj, 
+      obj,
       propertyName
       );
   }
@@ -165,4 +169,4 @@ export class ObjectObservationAdapter {
   getObserver(object, propertyName) {
     throw new Error('BindingAdapters must implement createObserver(object, propertyName).');
   }
-}
+}
diff --git a/dist/es6/property-observation.js b/dist/es6/property-observation.js
@@ -71,19 +71,21 @@ export class SetterObserver {
     this.setValue = this.setterValue;
     this.getValue = this.getterValue;
 
-    Object.defineProperty(this.obj, this.propertyName, {
-      configurable: true,
-      enumerable: true,
-      get: this.getValue.bind(this),
-      set: this.setValue.bind(this)
-    });
+    try{
+      Object.defineProperty(this.obj, this.propertyName, {
+        configurable: true,
+        enumerable: true,
+        get: this.getValue.bind(this),
+        set: this.setValue.bind(this)
+      });
+    }catch(_){}
   }
 }
 
 export class OoObjectObserver {
   constructor(obj){
     this.obj = obj;
-    this.observers = {};  
+    this.observers = {};
   }
 
   subscribe(propertyObserver, callback){
@@ -92,7 +94,9 @@ export class OoObjectObserver {
 
     if(!this.observing){
       this.observing = true;
-      Object.observe(this.obj, changes => this.handleChanges(changes), ['update', 'add']);
+      try{
+        Object.observe(this.obj, changes => this.handleChanges(changes), ['update', 'add']);
+      }catch(_){}
     }
 
     return function(){
@@ -111,11 +115,11 @@ export class OoObjectObserver {
     var updates = {},
         observers = this.observers,
         i = changeRecords.length;
-    
+
     while(i--) {
       var change = changeRecords[i],
           name = change.name;
-  
+
       if(!(name in updates)){
         var observer = observers[name];
         updates[name] = true;
@@ -202,9 +206,9 @@ export class ElementObserver {
     }
 
     var callbacks = this.callbacks;
-    
+
     callbacks.push(callback);
-    
+
     return function(){
       callbacks.splice(callbacks.indexOf(callback), 1);
       if(callback.length === 0){

diff --git a/dist/system/observer-locator.js b/dist/system/observer-locator.js
@@ -7,25 +7,29 @@ System.register(["aurelia-task-queue", "./array-observation", "./event-manager",
   function createObserversLookup(obj) {
     var value = {};
 
-    Object.defineProperty(obj, "__observers__", {
-      enumerable: false,
-      configurable: false,
-      writable: false,
-      value: value
-    });
+    try {
+      Object.defineProperty(obj, "__observers__", {
+        enumerable: false,
+        configurable: false,
+        writable: false,
+        value: value
+      });
+    } catch (_) {}
 
     return value;
   }
 
   function createObserverLookup(obj) {
     var value = new OoObjectObserver(obj);
 
-    Object.defineProperty(obj, "__observer__", {
-      enumerable: false,
-      configurable: false,
-      writable: false,
-      value: value
-    });
+    try {
+      Object.defineProperty(obj, "__observer__", {
+        enumerable: false,
+        configurable: false,
+        writable: false,
+        value: value
+      });
+    } catch (_) {}
 
     return value;
   }

diff --git a/dist/system/property-observation.js b/dist/system/property-observation.js
@@ -100,12 +100,14 @@ System.register([], function (_export) {
               this.setValue = this.setterValue;
               this.getValue = this.getterValue;
 
-              Object.defineProperty(this.obj, this.propertyName, {
-                configurable: true,
-                enumerable: true,
-                get: this.getValue.bind(this),
-                set: this.setValue.bind(this)
-              });
+              try {
+                Object.defineProperty(this.obj, this.propertyName, {
+                  configurable: true,
+                  enumerable: true,
+                  get: this.getValue.bind(this),
+                  set: this.setValue.bind(this)
+                });
+              } catch (_) {}
             },
             writable: true,
             configurable: true
@@ -129,9 +131,11 @@ System.register([], function (_export) {
 
               if (!this.observing) {
                 this.observing = true;
-                Object.observe(this.obj, function (changes) {
-                  return _this.handleChanges(changes);
-                }, ["update", "add"]);
+                try {
+                  Object.observe(this.obj, function (changes) {
+                    return _this.handleChanges(changes);
+                  }, ["update", "add"]);
+                } catch (_) {}
               }
 
               return function () {

diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
@@ -1,3 +1,11 @@
+### 0.3.4 (2015-02-06)
+
+
+#### Bug Fixes
+
+* **observers:** do not fail on primitive observation attempt ([854930a5](http://github.com/aurelia/binding/commit/854930a50685836111f97119b1295e07190d6f34))
+
+
 ### 0.3.3 (2015-02-03)
 
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "aurelia-binding",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "A modern databinding library for JavaScript and HTML.",
   "keywords": [
     "aurelia",