feat(rxjs) update rxjs to be a peerDependency (v6 or v7) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows consuming projects to upgrade to rxjs 7 without a version resolution override for aurelia-store. Without this change, build systems would bundle both versions and warn of the duplication. Modifications: - Install RXJS 7 as a devDependency for the local build - Update TypeScript to 4.3 for compatibility with RXJS 7 - Update other build devDependencies to fix build errors with new versions Possible breaking changes: `rxjs` would have to be installed in the consuming project, which might not be automatic with older versions of npm. Anyone using the plugin would likely already be using RXJS to interact with the store, though.
|
I signed the CLA a few years ago for an update to the logging library. Hopefully it's still valid, but I can do it again if I need to. Is the CI error below something I can resolve? The tests themselves passed, and the uncovered lines were already there in master. |
|
Thanks for the contrib @krisdages. The CLA is no longer needed so all good. Updating TS will certainly result in a breaking change so I'll give your PR a proper look next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows consuming projects to upgrade to rxjs 7 without a version
resolution override for aurelia-store.
Without this change, build systems would bundle both versions
and warn of the duplication.
Modifications:
Possible breaking changes:
rxjswould have to be installed in the consuming project, which might not beautomatic with older versions of npm. Anyone using the plugin would
likely already be using RXJS to interact with the store, though.