Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(update): update bindings helper #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zewa666
Copy link
Member

@zewa666 zewa666 commented Jan 14, 2018

adds a helper function to flush the microtaskqueue so that testing binding changes becomes easier

adds a helper function to flush the microtaskqueue so that testing binding changes becomes easier
@zewa666
Copy link
Member Author

zewa666 commented Jan 14, 2018

Hey @bigopon I could need some help with getting the tests to work. Funny enough using the updateBindings helper in an app works flawlessly but not inside the testing repos tests themselves.

@bigopon
Copy link
Member

bigopon commented Jan 14, 2018

I can reproduce it. I'll check and update

@bigopon
Copy link
Member

bigopon commented Jan 14, 2018

The task queue that component view model observers uses is not the same task queue getting from global Container. I'm not sure why. Without proper debugger I think it's hard to observe the behavior. Maybe @jdanyow / @EisenbergEffect can give some help

@zewa666
Copy link
Member Author

zewa666 commented Jan 14, 2018

I had the same Idea but even picking the aurelia.container during bootstrapping, which should be the right one, didnt help. I wonder whether its because of the way how the initialization is setup, pointing to the dist folder. I'll try to switch that similar to how I did it with i18n and see whether this helps.

@silbinarywolf
Copy link

@zewa666 Did you have any luck with this or have any other information that will help in getting this PR over the line?

I'd like to remove my setTimeout() hack for testing two-way binding :)

@Alexander-Taran
Copy link

@bigopon @zewa666
should we merge this?

@bigopon
Copy link
Member

bigopon commented Feb 10, 2019

Let me fix it first. I'll create a PR shortly

@bigopon
Copy link
Member

bigopon commented Feb 10, 2019

I think we will have to delay this feature for awhile, unless we fix some issues related to resources
registration with container first. setTimeout(, 0) or await Promise.resolve() could be appropriate for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants