Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix istanbul bug #547

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Fix istanbul bug #547

merged 2 commits into from
Apr 15, 2020

Conversation

saqibnoorani
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bigopon
Copy link
Member

bigopon commented Apr 3, 2020

@saqibnoorani it is difficult to merge or even proceed this PR without any test, or even the comment. Could you please help with at least adding the test based on the examples innthe linked issue?

@saqibnoorani
include the test cases to test regex functionality of getAccessorExpr…
b59d63d 
…ession

The old classic regex expression fails when istanbul coverage is set to true. I have updated the classic regex expression with the new one . The test cases wont fails when generating code coverage through istanbul
@saqibnoorani
Copy link
Contributor Author

@bigopon I have included the test scenario where in the old regex fails.

@fkleuver
Copy link
Member

fkleuver commented Apr 3, 2020

This makes sense to me. Might also solve some other rare issues.
I don't see how this can do any harm so since the test passes, as far as I'm concerned we should be good.
Thanks @saqibnoorani

@Sayan751
Copy link
Member

Sayan751 commented Apr 4, 2020

@saqibnoorani Thanks for the fix. I will keep this in mind for AU2 :)

@fkleuver
Copy link
Member

fkleuver commented Apr 7, 2020

@bigopon do you think this is good to go?

@bigopon
Copy link
Member

bigopon commented Apr 7, 2020

Yes. I think if any folks complain, we will fix it by exporting a way to make the parser override-able. Its my biggest concern for this, but it shouldnt break any

@Sayan751 Sayan751 mentioned this pull request Apr 9, 2020
Merged
@fkleuver fkleuver merged commit b19ecd7 into aurelia:master Apr 15, 2020
@hiaux0 hiaux0 mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saqibnoorani @CLAassistant @bigopon @fkleuver @Sayan751