Add CI for checking committer(s) email(s) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Looks good in terms of doing checking what it is supposed. But I don't think this will do anything about the committer emails be from the aurora domain. We all push commits using our aurora emails. The issue is the commits GitHub creates when you merge a PR via the web interface as signed using personal emails. The way to eliminate personal emails is to always merge PRs via the command line, never via the web interface.
joshuajbouw
approved these changes
Nov 19, 2021
|
Should we revive this @strokovok ? |
|
@joshuajbouw @strokovok do we still need to enforce this check ? |
mrLSD
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse this workflow for checking that committers' emails are suffixed with "@aurora.dev"