Enable std #530
Open
Enable std #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
suggested changes
Jun 8, 2022
There was a problem hiding this comment.
Theres a bit more to be done. I wouldn't add it as a feature.Just make it only std.
These need to be removed under features in each Cargo.toml:
std = ["borsh/std", "evm/std", "primitive-types/std", "rlp/std", "sha3/std", "ethabi/std", "logos/std", "bn/std", "aurora-engine-types/std", "rjson/std", "aurora-engine-precompiles/std", "aurora-engine-transactions/std"]
Also, any dependency that has default-features = false needs to be removed as we won't be going back to no_std.
sept-en
reviewed
Jun 9, 2022
joshuajbouw
approved these changes
Jun 22, 2022
|
Task linked: CU-2e6u98n |
|
Please resolve conflicts and squash. |
joshuajbouw
force-pushed
the
feat/std-wasm32
branch
from
d3a1ac6
to
f1c4810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
stdBy introducing this compilation option (feature), we are able to include the standard rust library.
Measured binary size (release):
std: 1018479std: 1016468 (-2%)Exclusions
Not all dependencies turn off as
no-defaults. For some reason, it is several crates that compilation success but unit tests failed.Reason
There are some dependencies we use which we had to fork and make non-std. The problem is that we need to be active and update these libraries with upstream. Critical issues on these upstream libraries may not easily notify us of any issues, and we may be left with a critical bug for some time.
The second issue is that we can be limited in the dependencies that we want to use. At times, a task which should take a day could take a week at times, for example.
Reverting to std will increase gas usage slightly, but will make the engine more maintainable.