feat: remove owner requirement on deploying a staged upgrade #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
added
C-enhancement
aleksuss
approved these changes
Jul 18, 2023
joshuajbouw
added a commit
that referenced
this pull request
Jul 20, 2023
Given that there are precautions to remove a staged upgrade, and only the owner or DAO can stage an upgrade, removing the owner's requirement of deploying the upgrade is safe. We started running into a potential issue where it may be too costly for the DAO to deploy future Engine releases. While there is currently no issue to stage a release, a deployment may, in fact be a bit too costly. The DAO almost hit this limit previously as 280 Tgas was the gas required via the DAO. Additionally, this reduces the DAO votes by 1 as now they only have to vote on an upgrade which needs to be staged. This should be done as a patch release on the master branch prior to any further deployments. --------- Co-authored-by: Oleksandr Anyshchenko <[email protected]>
Merged
joshuajbouw
added a commit
that referenced
this pull request
Jul 20, 2023
This is a quick patch to ensure that there are no complications when deploying from a DAO as we are running close to the 300 Tgas gas limit when doing `deploy_upgrade`, and reduces the amount of votes required by a DAO for deployment to a single vote. ## Changes - It is now possible for anyone to call the contract method `deploy_upgrade` by @joshuajbouw. #794 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Oleksandr Anyshchenko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mrLSD
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given that there are precautions to remove a staged upgrade, and only the owner or DAO can stage an upgrade, removing the owner's requirement of deploying the upgrade is safe.
Additional Information
We started running into a potential issue where it may be too costly for the DAO to deploy future Engine releases. While there is currently no issue to stage a release, a deployment may, in fact be a bit too costly. The DAO almost hit this limit previously as 280 Tgas was the gas required via the DAO. Additionally, this reduces the DAO votes by 1 as now they only have to vote on an upgrade which needs to be staged.
This should be done as a patch release on the master branch prior to any further deployments.