Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Refactore transact_create functions #66

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Oct 15, 2024

Description

After investigation, I found, that some logic is double executed. I suppose this is clearly a result of a lack of attention to detail when adding new functionality. It also brings some micro-optimizations.

This refactoring is important for the context of EOFv1 (Prague hard fork) implementation, as it's strictly related.

➡️ transact_create - removed redundand nonce USIZE_MAX, because it's checked after that in create_inner.
➡️ transact_create , transact_create2, transact_create_fixed - removed warming for address value as it's MUST be warmed in create_inner function.
➡️ Explicitly removed address value from all transact_create as redundant, because it's calculated in create_inner. It was moved to trace events (which is under the feature flag).
➡️ Refactored warming access_list for transact_* functions - values arguments as slice, and now it's more flexible as it takes also a slice as an argument for warming addresses.
⚠️ BREAKING CHANGES: changed annotation for all transact_* functions for access_list form Vec to slice. MOTIVATION: reduce heap-allocated values copy.

@mrLSD mrLSD self-assigned this Oct 15, 2024
@mrLSD mrLSD added the enhancement New feature or request label Oct 15, 2024
@mrLSD mrLSD added this to the v0.47.0-aurora milestone Oct 15, 2024
@mrLSD mrLSD modified the milestones: v0.47.0-aurora, v0.46.1-aurora Oct 17, 2024
@mrLSD mrLSD merged commit aca614c into master Oct 17, 2024
6 checks passed
@mrLSD mrLSD deleted the feat/refactore-access-list branch October 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants