Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move solvers into ProblemOperator classes #110

Open
wants to merge 20 commits into
base: EdwardPalmer99/mesh-update-feature/add-problem-operator-base-class
Choose a base branch
from
Open

Move solvers into ProblemOperator classes #110

wants to merge 20 commits into from

Conversation

EdwardPalmer99
Copy link
Contributor

@EdwardPalmer99 EdwardPalmer99 commented May 20, 2024 •
edited
Loading

Changes

  • Moved solvers into ProblemOperatorBase.
  • Using unique pointers for solvers rather than shared pointers.
  • Moved block vector to ProblemOperatorBase.
  • Added wrapper methods for Step and Solve so executioners do not need to access solvers directly.

Edward Palmer added 9 commits May 20, 2024 14:10
Adds ProblemOperatorBase class; ProblemOperatorInterface now only con…
2552c43 
…tains pure virtual methods.
Removes unused equation system operator handle from ProblemOperatorBase.
1b93191
Adds Width and Height getter/setter to ProblemOperatorInterface; Remo…
803284f 
…ves UpdateOperatorWidthAndHeight method.
Removes ProblemOperatorInterface; now using base class ProblemOperato…
21e5c75 
…rBase.
Added comments to ProblemOperatorBase methods.
3562141
Deleted default ProblemOperatorBase constructor and made constructor …
19f10a4 
…protected to prevent direct construction of the base class.
Made UpdateOffsetsWithSize non-virtual.
0bffc69
Removed UpdateOffsetsWithSize; added GetSolutionVectorSize and GetTri…
8d57a18 
…alVariablesSize methods.
UpdateOffsets and UpdateBlockVector are now private methods; no longe…
c76733b 
…r virtual
@EdwardPalmer99 EdwardPalmer99 changed the base branch from master to EdwardPalmer99/mesh-update-feature/handle-update-initial-version May 20, 2024 14:20
@EdwardPalmer99 EdwardPalmer99 changed the base branch from EdwardPalmer99/mesh-update-feature/handle-update-initial-version to EdwardPalmer99/mesh-update-feature/add-problem-operator-base-class May 20, 2024 16:15
@EdwardPalmer99 EdwardPalmer99 self-assigned this May 20, 2024
Edward Palmer added 6 commits May 22, 2024 09:46
Moved ODE solver into TimeDomainProblemOperator.
c1e60ea
Block vector is now stored in ProblemOperatorBase; Added wrapper Step…
63d0c6a 
… and Solve methods to problem operators which use stored ode solver.
Removed ODE solver accessor from TimeDomainProblemOperator.
9990315
Removes ConstructJacobianPreconditioner method; moves preconditioner …
58814f8 
…setup into ConstructJacobianSolver.
Removed ConstructJacobianSolverWithOptions. All derived ProblemBuilde…
91275f4 
…r classes will create a jacobian solver / preconditioner, set their options and then pass it to the problem's operator.
Revert "Removed ConstructJacobianSolverWithOptions. All derived Probl…
ace7f88 
…emBuilder classes will create a jacobian solver / preconditioner, set their options and then pass it to the problem's operator."

This reverts commit 91275f4.
@EdwardPalmer99 EdwardPalmer99 marked this pull request as ready for review May 22, 2024 12:42
@EdwardPalmer99 EdwardPalmer99 force-pushed the EdwardPalmer99/mesh-update-feature/add-problem-operator-base-class branch from c76733b to fbb6fe4 Compare July 12, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderianblair alexanderianblair Awaiting requested review from alexanderianblair

Assignees

@EdwardPalmer99 EdwardPalmer99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EdwardPalmer99