Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved InputParameters #114

Closed
wants to merge 18 commits into from
Closed

Improved InputParameters #114

wants to merge 18 commits into from

Conversation

EdwardPalmer99
Copy link
Contributor

@EdwardPalmer99 EdwardPalmer99 commented Jun 4, 2024 •
edited
Loading

  • Cleans-up the InputParameters class.
  • Adds documentation.
  • Adds methods to Remove and Clear parameters.
  • Brings class more in-line with MOOSE. Ultimately, for Platypus it would make sense to use Moose's input parameters class.

Edward Palmer added 18 commits June 3, 2024 15:32
Removes repeated [[nodiscard]].
a30bde0
Removes unnecessary semicolons.
3f6ab2d
Moves protected section beneath public to be consistent; adds new-lin…
40e8727 
…es to space-out code.
Renamed InputParameters constructor argument to be consistent.
8c352ba
Adds "AddParam", "Set" and "Has" methods to InputParameters.
bd81e98
Adds "Get" method which returns non-writable reference to parameter.
8db7ecc
Const-qualified Get method.
2abcdd6
Adds "CheckForMissingParam", "CheckForDuplicateParam".
67aac7f
Switched to an unordered params map.
165d133
Makes params map private.
06d9739
Adds "Clear" method to input parameters.
95d492f
Get returns a copy of the stored type; removes Set method which retur…
da57018 
…ns a writable reference.
Replaces GetParam with Get method.
b3ad0da
Simplifies GetOptionalParam; Removes CheckForDuplicatedParam; Removes…
c90b3bd 
… AddParam.
Renames SetParam to Set.
111ece5
Renames GetOptionalParam to GetOptional.
f5899ad
Adds exception handling in Get method.
bf7a552
Adds Remove method to InputParameters.
36e7f98
@EdwardPalmer99 EdwardPalmer99 changed the title Edward palmer99/mesh update feature/improved input parameters Improved InputParameters Jun 4, 2024
@EdwardPalmer99 EdwardPalmer99 self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@EdwardPalmer99 EdwardPalmer99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EdwardPalmer99