Add ability to drive sequential ASCOT5 runs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AscotProblem::externalSolve() has not been implemented, so this new test fails here.
Unit test to check that this call has executed passes.
It now separates the data for the quick run from the normal run
This is following the discovery that multiple threads can cause variability between runs. OMP_NUM_THREADS=1 is therefore now used for tests and generating test data.
…extracted for a restart
…being retained in the repo
Also, correct and error in the integer test data. SI units need to be turned off.
Correct the creation of the double data which had insufficient precision and required SI units to be turned off for the mass.
This is for unit test data.
The endstate values that ended up in a new marker group have now been copied over to the active subgroup so that `h5diff` should work when comparing these subgroups from test runs.
By correct time option set, it is meant that no just dt (the time step) should be written to the ASCOT5 input, but time() + dt() because ASCOT5 uses the cumulative time for end conditions.
…d not the '.h5' stripped like ASCOT5 expects The stripping of the .h5 extension is now done within the code before calling ASCOT5. This is more consistent and understandable.
Implement test of this class method also, with corresponding updates to the test data.
Remove the other regression test for reading HDF5 data because it was actually an integration test that didn't run the app end-to-end, and with the fully implemented AscotProblem, it is likely no longer possible to do this type of test with the regression test system of MOOSE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in the long chain of changes needed to get Phaethon to drive ASCOT5 over multiple times steps. This completes the first Phaethon prototype. It should be possible to incorporate Phaethon as a sub-app that ties into a heat conduction problem, where fluxes provided to the heat conduction problem are from the fast ions.
This closes #3