Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe Swift code from OTP code generation #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emiliopavia
Copy link

@emiliopavia emiliopavia commented Dec 20, 2022

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

On iOS 16 we're receiving several exceptions from the code(counter:) function in OneTimePasswordGenerator. The exception is related to the block called in the withUnsafeBytes function.

This PR aims to replace the code without using unsafe pointers (as suggested by Apple in Swift support forums).

References

Testing

The code is already covered by tests.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@ObidosDev
Copy link

Any update on this?
Looks like this code produce error Fatal error: self must be a properly aligned pointer for types Pointee and T on line let value = start.withMemoryRebound(to: UInt32.self, capacity: 1) { $0 }
This PR may fix it :)

@ObidosDev
Copy link

@Widcket may you take a look?

@Widcket
Copy link
Contributor

Widcket commented Jan 9, 2023

Hi @emiliopavia and @ObidosDev, thanks for raising this. However, I'm not the maintainer of this library –I'll defer to @ionutmanolache-okta.

@ObidosDev
Copy link

Any update on this? This is kinda huge problem for now

@ObidosDev
Copy link

Updates?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants