Skip to content

Commit

Permalink
Fix lint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ewanharris committed Jul 31, 2023
1 parent 5fb7ba0 commit 51fd243
Show file tree
Hide file tree
Showing 10 changed files with 4 additions and 13 deletions.
4 changes: 2 additions & 2 deletions internal/cli/actions.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func createActionCmd(cli *cli) *cobra.Command {
return err
}

triggers, err := getCurrentTriggers(cli, cmd.Context())
triggers, err := getCurrentTriggers(cmd.Context(), cli)
if err != nil {
return err
}
Expand Down Expand Up @@ -518,7 +518,7 @@ func filterDeprecatedActionTriggers(list []*management.ActionTrigger) []*managem
return res
}

func getCurrentTriggers(cli *cli, ctx context.Context) ([]*management.ActionTrigger, error) {
func getCurrentTriggers(ctx context.Context, cli *cli) ([]*management.ActionTrigger, error) {
var triggers []*management.ActionTrigger
if err := ansi.Waiting(func() error {
list, err := cli.api.Action.Triggers(ctx)
Expand Down
1 change: 0 additions & 1 deletion internal/cli/apis.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ func listApisCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.Number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
apiList, err := cli.api.ResourceServer.List(cmd.Context(), opts...)
Expand Down
1 change: 0 additions & 1 deletion internal/cli/apps.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ func listAppsCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.Number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
opts = append(opts, management.Parameter("is_global", "false"))
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/email_templates.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ func updateEmailTemplateCmd(cli *cli) *cobra.Command {
return cmd
}

func (c *cli) emailTemplatePickerOptions(ctx context.Context) (pickerOptions, error) {
func (c *cli) emailTemplatePickerOptions(_ context.Context) (pickerOptions, error) {
return emailTemplateOptions, nil
}

Expand Down
3 changes: 0 additions & 3 deletions internal/cli/organizations.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ func listOrganizationsCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.Number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
res, err := cli.api.Organization.List(cmd.Context(), opts...)
Expand Down Expand Up @@ -721,7 +720,6 @@ func formatOrganizationDetailsPath(id string) string {
}

func getWithPagination(
context context.Context,
limit int,
api func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error),
) ([]interface{}, error) {
Expand Down Expand Up @@ -766,7 +764,6 @@ func (cli *cli) getOrgMembers(
number int,
) ([]management.OrganizationMember, error) {
list, err := getWithPagination(
context,
number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, apiErr error) {
members, apiErr := cli.api.Organization.Members(context, url.PathEscape(orgID), opts...)
Expand Down
1 change: 0 additions & 1 deletion internal/cli/roles.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ func listRolesCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.Number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
roleList, err := cli.api.Role.List(cmd.Context(), opts...)
Expand Down
1 change: 0 additions & 1 deletion internal/cli/roles_permissions.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ func listRolePermissionsCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.Number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
permissionsList, err := cli.api.Role.Permissions(cmd.Context(), inputs.ID, opts...)
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/tenants.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func selectValidTenantFromConfig(cli *cli, cmd *cobra.Command, args []string) (s
return selectedTenant, err
}

func (c *cli) tenantPickerOptions(ctx context.Context) (pickerOptions, error) {
func (c *cli) tenantPickerOptions(_ context.Context) (pickerOptions, error) {
tenants, err := c.Config.ListAllTenants()
if err != nil {
return nil, fmt.Errorf("failed to load tenants: %w", err)
Expand Down
1 change: 0 additions & 1 deletion internal/cli/users.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ func searchUsersCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
opts = append(opts, queryParams...)
Expand Down
1 change: 0 additions & 1 deletion internal/cli/users_roles.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ func showUserRolesCmd(cli *cli) *cobra.Command {
}

list, err := getWithPagination(
cmd.Context(),
inputs.Number,
func(opts ...management.RequestOption) (result []interface{}, hasNext bool, err error) {
userRoleList, err := cli.api.User.Roles(cmd.Context(), inputs.ID, opts...)
Expand Down

0 comments on commit 51fd243

Please sign in to comment.