Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-677 : Support different strategies connection while creating a user #1091

Merged

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Oct 9, 2024

🔧 Changes

Support to create users with passwordless connections

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 43.56436% with 114 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (e7536d4) to head (ea6f222).

Files with missing lines Patch % Lines
internal/cli/users.go 48.33% 82 Missing and 11 partials ⚠️
internal/display/users.go 4.54% 17 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   72.11%   71.70%   -0.42%     
==========================================
  Files          94       94              
  Lines       12978    13099     +121     
==========================================
+ Hits         9359     9392      +33     
- Misses       3071     3153      +82     
- Partials      548      554       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramya18101 ramya18101 marked this pull request as ready for review October 16, 2024 05:39
@ramya18101 ramya18101 requested a review from a team as a code owner October 16, 2024 05:39
@ramya18101 ramya18101 merged commit c5f2f43 into main Oct 17, 2024
11 checks passed
@ramya18101 ramya18101 deleted the DXCDT-677-Support-create-user-with-passwordless-connection branch October 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants