Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Normalize action code paths for directory format exports #1009

Merged

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Jan 7, 2025

🔧 Changes

Fix: Normalize action code paths for directory format exports

{
  "name": "action-one",
+ "code": "./actions/action-one/code.js",
- "code": "local/actions/action-one/code.js",
  "runtime": "node18-actions",
  "status": "built",
  "dependencies": [],
  "secrets": [],
  "supported_triggers": [
    {
      "id": "post-login",
      "version": "v3"
    }
  ],
  "deployed": true
}

📌 The import command is backwards compatible supports both:

"code": "./actions/action-one/code.js",
"code": "local/actions/action-one/code.js",

📚 References

#899
#873

🔬 Testing

Test passed

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (83d31b9) to head (0914ccb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   80.20%   80.20%           
=======================================
  Files         125      125           
  Lines        4562     4562           
  Branches      884      884           
=======================================
  Hits         3659     3659           
  Misses        535      535           
  Partials      368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 marked this pull request as ready for review January 7, 2025 11:38
@kushalshit27 kushalshit27 requested a review from a team as a code owner January 7, 2025 11:38
@kushalshit27 kushalshit27 merged commit 8e7bd4c into master Jan 7, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-803-actions-actions-export-absolute-path-for-code branch January 7, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants