-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for listing authenticators and deleting specific authenticator #698
Open
czf
wants to merge
3
commits into
auth0:master
Choose a base branch
from
czf:mfa-delete
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using Newtonsoft.Json; | ||
|
||
namespace Auth0.AuthenticationApi.Models | ||
{ | ||
public class Authenticator | ||
{ | ||
[JsonProperty("id")] | ||
public string Id { get; set; } | ||
|
||
[JsonProperty("authenticator_type")] | ||
public string AuthenticatorType { get; set; } | ||
|
||
[JsonProperty("active")] | ||
public bool Active { get; set; } | ||
|
||
[JsonProperty("oob_channel")] | ||
public string OobChannel { get; set; } | ||
|
||
[JsonProperty("name")] | ||
public string Name { get; set; } | ||
} | ||
} |
19 changes: 19 additions & 0 deletions
19
src/Auth0.AuthenticationApi/Models/DeleteMfaAuthenticatorRequest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Text; | ||
|
||
namespace Auth0.AuthenticationApi.Models | ||
{ | ||
public class DeleteMfaAuthenticatorRequest | ||
{ | ||
/// <summary> | ||
/// Access token with scope: remove:authenticators and audience: https://{yourDomain}/mfa/ | ||
/// </summary> | ||
public string AccessToken { get; set; } | ||
|
||
/// <summary> | ||
/// The ID of the authenticator to delete. | ||
/// </summary> | ||
public string AuthenticatorId { get; set; } | ||
} | ||
} |
45 changes: 45 additions & 0 deletions
45
tests/Auth0.AuthenticationApi.IntegrationTests/MfaTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
using System.Linq; | ||
using System.Threading.Tasks; | ||
using Auth0.AuthenticationApi.Models; | ||
using Auth0.Tests.Shared; | ||
using FluentAssertions; | ||
using Xunit; | ||
|
||
namespace Auth0.AuthenticationApi.IntegrationTests | ||
{ | ||
public class MfaTests : TestBase | ||
{ | ||
public MfaTests() | ||
{ | ||
_authenticationApiClient = new AuthenticationApiClient(GetVariable("AUTH0_AUTHENTICATION_API_URL")); | ||
} | ||
|
||
private readonly AuthenticationApiClient _authenticationApiClient; | ||
|
||
[Fact(Skip = "Run manually")] | ||
public async Task Invoking_Delete_ShouldNotThrow() | ||
{ | ||
await _authenticationApiClient.Invoking( | ||
x => x.DeleteMfaAuthenticatorAsync( | ||
new DeleteMfaAuthenticatorRequest() | ||
{ | ||
AccessToken = GetVariable("MFA_ACCESS_TOKEN"), | ||
AuthenticatorId = GetVariable("AUTHENTICATOR_ID") | ||
})).Should().NotThrowAsync(); | ||
} | ||
|
||
[Fact(Skip = "Run manually")] | ||
public async Task Should_Return_Authenticators() | ||
{ | ||
var response = await _authenticationApiClient.ListAuthenticatorsAsync( | ||
GetVariable("MFA_ACCESS_TOKEN") | ||
); | ||
|
||
response.Should().NotBeNullOrEmpty(); | ||
response.First().AuthenticatorType.Should().NotBeNullOrEmpty(); | ||
response.First().OobChannel.Should().NotBeNullOrEmpty(); | ||
response.First().Id.Should().NotBeNullOrEmpty(); | ||
response.First().Name.Should().NotBeNullOrEmpty(); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need to introduce this kind of validation here.Currently, we rely on the backend to tell us if something is missing, mainly because it isn't always clear what is and isnt required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this