-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(management): add DeviceCredentialsManager to mange device credentials #369
base: main
Are you sure you want to change the base?
Conversation
d909447
to
1c931a5
Compare
1c931a5
to
8ab22cb
Compare
8ab22cb
to
ad40d7b
Compare
ad40d7b
to
b7908f0
Compare
@ewanharris Hi. Any chance you could review this when you have time? |
b7908f0
to
031e4c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 95.34% 95.36% +0.02%
==========================================
Files 47 48 +1
Lines 7558 7598 +40
==========================================
+ Hits 7206 7246 +40
Misses 235 235
Partials 117 117 ☔ View full report in Codecov by Sentry. |
Hey @Zarux , I hope you're doing well. As I was going through the PR, I wanted to share some thoughts with you. I've noticed a few areas where we could potentially improve, particularly in the test cases. Using getters throughout the codebase can offer some significant benefits, especially in GoLang. Additionally, incorporating random functions into our test details could greatly enhance the robustness of our testing framework. This approach ensures that even when we're dealing with multiple test cases, like creating or deleting tests, we're less likely to encounter errors along the way. If you'd like, you can check out this link for a reference: https://github.com/auth0/go-auth0/blob/main/management/connection_test.go Let me know if you have any questions or need further clarification! |
The management API is currently lacking support for the device-credentials endpoints. This PR adds the availabe methods for that endpoint.
https://auth0.com/docs/api/management/v2/device-credentials/get-device-credentials
🔧 Changes
Added support for Device Credentials in the management API with the methods:
DeviceCredentials.Create
DeviceCredentials.List
DeviceCredentials.Delete
🔬 Testing
All new methods added have corresponding tests
📝 Checklist