Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin crypto-js to 3.3.0 #131

Merged
merged 1 commit into from
May 26, 2021
Merged

Pin crypto-js to 3.3.0 #131

merged 1 commit into from
May 26, 2021

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This PR pins crypto-js to 3.3.0. The
current version requires a native implemenation of crypto, which breaks
dependents further up the chain who do not have an immediate resolution
available.

References

brix/crypto-js#262

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner May 26, 2021 12:14
@stevehobbsdev stevehobbsdev merged commit c455d38 into master May 26, 2021
@stevehobbsdev stevehobbsdev deleted the deps/crypto branch May 26, 2021 12:38
@stevehobbsdev stevehobbsdev added this to the v2.1.2 milestone May 26, 2021
@stevehobbsdev stevehobbsdev mentioned this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants