[IAMRISK-3554] hcaptcha bug fix #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-cain
reviewed
Jun 17, 2024
| @@ -302,7 +302,7 @@ export class ThirdPartyCaptcha extends React.Component { | |||
| : `auth0-lock-${providerDomPrefix(this.props.provider)}-block auth0-lock-${providerDomPrefix(this.props.provider)}-block-error` | |||
| } | |||
| > | |||
| <div className={`auth0-lock-${providerDomPrefix(this.props.provider) === 'recaptcha' ? 'recaptchav2' : providerDomPrefix(this.props.provider)}`} ref={this.ref} /> | |||
| <div className={`auth0-lock-${providerDomPrefix(this.props.provider) === 'recaptcha' ? 'recaptchav2' : providerDomPrefix(this.props.provider)}`} id={this.props.provider === HCAPTCHA_PROVIDER ? 'h-captcha' : ''} ref={this.ref} /> | |||
There was a problem hiding this comment.
Really starting to dislike the second ternary operator (starting to get significantly more difficult to follow and reason about). Any considerations for isolating this to a function the same way we did with providerDomPrefix?
There was a problem hiding this comment.
I can do that- I think that will make it easier to follow 👍
josh-cain
approved these changes
Jun 17, 2024
nandan-bhat
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There's an issue with hcaptcha dissapearing and not reloading. There's a related thread here that goes more in depth into the problem. The fix involves resetting the
window.hcaptchavariable to force a reload.References
Ticket
Testing
Checklist