-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IAMRISK-3539] Use signup captcha enforcement endpoint for signup flow #2586
Open
TSLarson
wants to merge
4
commits into
master
Choose a base branch
from
iamrisk-3539-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSLarson
commented
Oct 2, 2024
"auth0-password-policies": "^1.0.2", | ||
"blueimp-md5": "^2.19.0", | ||
"classnames": "^2.3.2", | ||
"dompurify": "^2.3.12", | ||
"dompurify": "^2.5.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated due to Snyk error in CI
TSLarson
commented
Oct 2, 2024
TSLarson
force-pushed
the
iamrisk-3539-3
branch
from
October 7, 2024 19:15
40c4785
to
480f75d
Compare
// there is no id for the unselected tab (Login is selected by default) | ||
const signUpTab = window.document['querySelector']('.auth0-lock-tabs > li:nth-child(2) > a'); | ||
Simulate.click(signUpTab, {}); | ||
} |
Check notice
Code scanning / CodeQL
Semicolon insertion Note test
Avoid automated semicolon insertion (98% of all statements in have an explicit semicolon).
the enclosing script
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR separates the bot detection enforcement policy from login and signup. When the signup screen is selected, the bot detection enforcement policy is now selected from the NEW signup endpoint.
References
https://auth0team.atlassian.net/browse/IAMRISK-4032
Testing
Checklist