Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate CI to GitHub #523

Merged
merged 7 commits into from
Sep 27, 2023
Merged

test: Migrate CI to GitHub #523

merged 7 commits into from
Sep 27, 2023

Conversation

evansims
Copy link
Member

Changes

This pull request replaces our current CircleCI continuous integration suite for auth0-react with a new workflow using GitHub Actions.

References

Please see internal ticket SDK-4457.

Testing

This pull request replaces our continuous integration suite with one built in GitHub's native Actions ecosystem. It aligns with other migrations taking place across our repositories.

Checklist

@evansims evansims added the review:small Small review label Sep 20, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@evansims evansims marked this pull request as ready for review September 20, 2023 04:49
@evansims evansims requested a review from a team as a code owner September 20, 2023 04:49
@evansims
Copy link
Member Author

@stevehobbsdev Thanks for your review! I've removed the gem-release dependency and updated the publishing workflow. I think I caught all the related bits and pieces, but let me know if I happened to overlook one.

Did a bit of research and found the reason GitHub suggests this approach. RubyGems < 3.0.5 did not support GEM_HOST_API_KEY variable for gem push, and instead required the use of that credentials file. So this approach covers all cases. I don't expect we'll have such an old version of it floating about these days, so it's indeed safe to remove that aspect 👍

@evansims evansims merged commit 83add4e into master Sep 27, 2023
9 checks passed
@evansims evansims deleted the test/github-ci-migration branch September 27, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants