-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configMap.yaml #237
base: master
Are you sure you want to change the base?
Conversation
Enable disabling of mysql/postgresql tls Signed-off-by: rarosalion <[email protected]>
Important Review SkippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
In case it's not clear from the code changes, for both mysql and postgresql (and, possibly other places?), the "tls:" block in the ConfigMap isn't optional, and forces authelia to try to use tls (even if tls.enabled=false). This change allows the tls.enabled=false setting to take effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to bump the chart version.
I think I've done that right. Let me know if you need anything else to get it merged. |
Enable disabling of tls on mysql/postgresql