Manage custom storage class using django.core.files.storage.storages … #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules instead of deprecated method In Django documentation we can see that get_storage_class is deprecated in Django 5.1 and later. https://docs.djangoproject.com/en/5.0/ref/files/storage/#django.core.files.storage.get_storage_class Recommendation of Django is to use storages instead of get_storage_class. This leads to specify this file storage backend in STORAGES config settings instead of a new config variable. This commit allows also to keep using custom storage classe from older verions (4.2 and earlier) and prevents to crash when invalid storage class is provided, using the default one. Solves auto-mat#115
timthelion
approved these changes
Apr 12, 2024
|
@JMSoler7 Does the storage identifier have to be exactly What if I would like to reuse some already existing storage, like |
|
I added more proper fix in PR #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…modules instead of deprecated method
In Django documentation we can see that get_storage_class is deprecated in Django 5.1 and later.
https://docs.djangoproject.com/en/5.0/ref/files/storage/#django.core.files.storage.get_storage_class
Recommendation of Django is to use storages instead of get_storage_class. This leads to specify this file storage backend in STORAGES config settings instead of a new config variable.
This commit allows also to keep using custom storage classe from older verions (4.2 and earlier) and prevents to crash when invalid storage class is provided, using the default one.
Solves #115