Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/components: add component TableNotifications for displaying user notifications #551

Merged
merged 10 commits into from
Sep 20, 2024

Conversation

maceksimon
Copy link
Contributor

Add component TableNotifications for displaying user notifications on Profile page.

  • Add Quasar table with custom slots.
  • Add Notification type based on Notification API endpoint.
  • Add TableColumn type to emulate Quasar table prop types and prevent typescript error.
  • Add translations
  • Add tests

@tmszi tmszi added the enhancement New feature or request label Sep 4, 2024
@tmszi
Copy link
Member

tmszi commented Sep 4, 2024

If I click on the table column Notification row link e.g. Challenge completed, should not be row marked as readed?

@tmszi
Copy link
Member

tmszi commented Sep 4, 2024

First table row Notification column with text New message is not behave as URL link, isn't that a bug?

@maceksimon
Copy link
Contributor Author

If I click on the table column Notification row link e.g. Challenge completed, should not be row marked as readed?

Yes, this is how it should work.
I implemented a onNotificationClick function that handles this basic case.

@maceksimon
Copy link
Contributor Author

First table row Notification column with text New message is not behave as URL link, isn't that a bug?

This is intended. In tableNotifications.json, the url is intentionally left out and so it displays title without a link.
Not sure if this can happen in production, but this way, the UI supports "non-clickable" notification if we need it.

@tmszi tmszi merged commit 2cb2202 into auto-mat:main Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants