Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/components/homepage: update NewsletterFeature styling based on graphic design #552

Merged
merged 5 commits into from
Sep 6, 2024
Merged

src/components/homepage: update NewsletterFeature styling based on graphic design #552

merged 5 commits into from
Sep 6, 2024

Conversation

maceksimon
Copy link
Contributor

Update NewsletterFeature styling based on graphic design file.

  • Update font size and color.
  • Update image.
  • Update row column width.
  • Update translation strings to accept dynamic user email (will be taken from login store).
  • Update props for the ability to override title and description.
  • Update and refactor tests.

@tmszi tmszi added the enhancement New feature or request label Sep 4, 2024
@tmszi
Copy link
Member

tmszi commented Sep 4, 2024

I can't open app locally, web browser console print bunch of warnings messages and one error message.

newsletter_feature_component_error_message

@maceksimon maceksimon force-pushed the feature/newsletter-feature-styling branch from 530c3f1 to 07ad5e0 Compare September 4, 2024 14:36
@tmszi tmszi force-pushed the feature/newsletter-feature-styling branch from b6fb3e7 to 6121078 Compare September 6, 2024 08:51
@tmszi tmszi merged commit bfbb70e into auto-mat:main Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmszi tmszi tmszi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maceksimon @tmszi