Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: Update Vue i18n to version 10.x with custom fixes for breaking changes #575

Closed

Conversation

maceksimon
Copy link
Contributor

Add "vue-i18n": "^10.0.0".
Fix issue with breaking change in test/cypress/support/commands.js.
Replace historic duplications of the command in CountdownEvent and DrawerHeader components.
Fix inconsistency between the use of Email label in translation strings.

@tmszi
Copy link
Member

tmszi commented Sep 20, 2024

Incorporate bug fix into PR #570 please.

@tmszi tmszi closed this Sep 20, 2024
@tmszi
Copy link
Member

tmszi commented Sep 20, 2024

Maybe it will be not working (incorporate bug fix commit into existed Mend Renovate PR), because permission settings.

@tmszi tmszi reopened this Sep 20, 2024
@maceksimon
Copy link
Contributor Author

Maybe it will be not working (incorporate bug fix commit into existed Mend Renovate PR), because permission settings.

Yes, I was not allowed to push to that branch. That's why I made a new one.
There is one more issue that does not seem to be related to i18n upgrade. I will test it in main. If present, I will fix it in a separate PR, if not I will try a fix here.

@maceksimon
Copy link
Contributor Author

PR #579 fixes the above issue. Once it is merged and this branch rebased, tests should pass.

@tmszi tmszi added the bug Something isn't working label Sep 23, 2024
@tmszi tmszi force-pushed the feature/vue-i18n-10.x-fixes branch 2 times, most recently from eedc3da to be1365c Compare September 24, 2024 04:25
@tmszi tmszi added enhancement New feature or request and removed bug Something isn't working labels Sep 24, 2024
@tmszi
Copy link
Member

tmszi commented Sep 24, 2024

Changes was incorporated in original upgrade vue-i18n Mend Renovate PR #570.

@tmszi tmszi closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants