Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding number of submission made to gradebook #1917

Closed
wants to merge 7 commits into from

Conversation

SimonMen65
Copy link
Contributor

@SimonMen65 SimonMen65 commented Jun 4, 2023

Summary

Summary generated by Reviewpad on 12 Nov 23 17:11 UTC

This pull request modifies the gradebook_helper.rb file in the app/helpers directory and the user.rb file in the app/models directory.

In gradebook_helper.rb:

  • Added a width property to the columns hash to set the width of certain columns in the gradebook.
  • Added a new column to display the submission version number.
  • Updated the width of the category average column.
  • Modified the gradebook_rows method to populate the new submission version column.

In user.rb:

  • Removed debug logging statements.

Overall, these changes enhance the gradebook display and remove unnecessary logging statements.

Description

Adding columns on how many times of trial has a student do in a certain assignment.

Motivation and Context

#1727

How Has This Been Tested?

So first under gradebook page, there are columns of "ver" added after each column of assignments.
version_show
Several Tests:

  • Adding submission from both student and admin page, version updated as Latest + 1
  • Delete a submission from admin management, version updated as Latest-1
  • For missing submission, means that students didn't submit at all, the placeholder of version is "-"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

@reviewpad reviewpad bot requested a review from 20wildmanj June 4, 2023 13:53
@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jun 4, 2023
@damianhxy
Copy link
Member

damianhxy commented Jun 4, 2023

Hi @SimonMen65, thank you for your contribution!

To facilitate reviewing, could you ensure the following

  • Give a descriptive title to this PR
  • Fleshing out the sections of the PR description, including
    • Motivation and Context: mention the issue that this PR closes
    • How has this been tested?: Screenshots of the interface, as well as a bulleted list of any tests you performed + the expected result. For example, performing a submission, creating a missing submission, deleting a submission
    • Type of changes: in this case, it's a new feature
    • Checklist: in this case, you should have run rubocop
  • Explicitly link the related issue (https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)

Furthermore, regarding the code in this PR

  • Avoid changing files unrelated to the PR, such as database.docker.yml and schema.rb
  • Removing debugging code, i.e. the use of Rails.logger.debug

@SimonMen65 SimonMen65 changed the title Issue1727 Adding number of submission made to gradebook Jun 26, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jun 26, 2023
@reviewpad reviewpad bot added small Pull request is small and removed large Pull request is large labels Jun 26, 2023
@20wildmanj
Copy link
Contributor

Tested out changes, verified that the Gradebook shows proper version numbers for assessments. I left some comments to be addressed

As an aside, if submissions that are less than the maximum version are destroyed, this would mean that the version number would be "off," but this doesn't really matter in the purpose of having a version number just to see how many times a student has submitted, so not worth addressing.

app/helpers/gradebook_helper.rb Show resolved Hide resolved
app/helpers/gradebook_helper.rb Show resolved Hide resolved
app/helpers/gradebook_helper.rb Show resolved Hide resolved
@damianhxy
Copy link
Member

Following up in #2005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose information about number of submissions made for each assignment in the gradebook
3 participants