-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding number of submission made to gradebook #1917
Conversation
Hi @SimonMen65, thank you for your contribution! To facilitate reviewing, could you ensure the following
Furthermore, regarding the code in this PR
|
Tested out changes, verified that the Gradebook shows proper version numbers for assessments. I left some comments to be addressed As an aside, if submissions that are less than the maximum version are destroyed, this would mean that the version number would be "off," but this doesn't really matter in the purpose of having a version number just to see how many times a student has submitted, so not worth addressing. |
Following up in #2005 |
Summary
Summary generated by Reviewpad on 12 Nov 23 17:11 UTC
This pull request modifies the
gradebook_helper.rb
file in theapp/helpers
directory and theuser.rb
file in theapp/models
directory.In
gradebook_helper.rb
:width
property to thecolumns
hash to set the width of certain columns in the gradebook.gradebook_rows
method to populate the new submission version column.In
user.rb
:Overall, these changes enhance the gradebook display and remove unnecessary logging statements.
Description
Adding columns on how many times of trial has a student do in a certain assignment.
Motivation and Context
#1727
How Has This Been Tested?
So first under gradebook page, there are columns of "ver" added after each column of assignments.
Several Tests:
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for lintingOther issues / help required
If unsure, feel free to submit first and we'll help you along.