-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to bulk import assessments from file system #1931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally everything works. However, on the frontend side the Import All button seems to remove only one assessment from the list per click, when it should remove them all.
To reproduce this:
- Add and remove 2 assessments.
- Click Import All.
- Observe that only one assessment is removed from the list, but that both are added to the course. If you refresh the page or click the button again, the list will be empty.
I've improved the javascript code so that the page only reloads after all ajax requests are complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides comment on post-bulk-install notification
* Update old-style path to use path helper * Add install all button * Rename install -> import * Improve logic * Add alert * Rephrase message * Rename btn variable (cherry picked from commit e885c67)
Summary
Summary generated by Reviewpad on 16 Jul 23 19:01 UTC
This pull request includes several patches that make various changes to the codebase. Here is a summary of each patch:
[PATCH 1/7] Update old-style path to use path helper:
[PATCH 2/7] Add install all button:
[PATCH 3/7] Rename install -> import:
[PATCH 4/7] Improve logic:
[PATCH 5/7] Add alert:
[PATCH 6/7] Rephrase message:
[PATCH 7/7] Rename btn variable:
Please review these patches and provide any necessary feedback or comments.
Description
Motivation and Context
Currently, assessments can only be individually imported from the file system. This PR provides an option to import all of them at once.
Closes #1928
How Has This Been Tested?
Create a course and a few assessments. Delete all of the assessments.
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting