-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate start_at during assessment import, remove unused db columns #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianhxy
changed the title
Propagate start_at during asmt import, remove unused asmt db columns
Propagate start_at during assessment import, remove unused db columns
Jul 1, 2023
20wildmanj
reviewed
Jul 8, 2023
20wildmanj
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed testing plan and did regression testing successfully, LGTM besides my leftover bug from before the PR
NicholasMy
pushed a commit
to UB-CSE-IT/Autolab
that referenced
this pull request
Jan 3, 2024
…autolab#1932) * Propagate start_at when applicable * Remove visible_at column * Remove has_autograde_old and has_scoreboard_old columns * Remove unused embedded_quiz code from assessments_controller#create * Remove embedded_quiz_form column * Update schema.rb * Fix end_at bug (cherry picked from commit ba39594)
NicholasMy
added a commit
to UB-CSE-IT/Autolab
that referenced
this pull request
Jan 4, 2024
* Remove visible_at column * Remove embedded_quiz_form column * Update schema.rb (cherry picked from commit ba39594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary generated by Reviewpad on 09 Jul 23 08:01 UTC
This pull request includes various changes across multiple files:
20230625125740_remove_visible_at_from_assessments.rb
has been added. It removes thevisible_at
column from theassessments
table in the database.remove_has_autograde_old_from_assessments.rb
has been added. It removes thehas_autograde_old
column from theassessments
table in the database.confirmInstall.html.erb
has been deleted. This file contained a JavaScript functionnewCat()
and a form for creating a new assessment.assessment.rb
has undergone changes related to thevisible_at
attribute in thedates
hash and its handling in theserialize
anddeserialize
methods.assessments_controller.rb
has multiple changes, including the removal of code related to visibility and embedded quiz functionality.RemoveEmbeddedQuizFormFromAssessments.rb
has been added. It removes theembedded_quiz_form
column from theassessments
table in the database.assessment_autograde_core.rb
has a change where thevisible_at
attribute is no longer assigned to the@visible_at
variable.20230625130526_remove_has_scoreboard_old_from_assessments.rb
has been added. It removes thehas_scoreboard_old
column from theassessments
table in the database.lib/tasks/autolab.rake
has changes related to the removal of thevisible_at
attribute.app/views/assessments/confirmInstall.html.erb
has been deleted. It contained JavaScript code and a form for creating assessments.schema.rb
file has various modifications, including changes to the schema version and columns in theannotations
andassessments
tables.These are the main changes found in the diff. Please review the individual summaries for more details.
Description
visible_at
column fromassessments
tablehas_autograde_old
column fromassessments
tablehas_scoreboard_old
column fromassessments
tableembedded_quiz_form
column fromassessments
table. Delete:embedded_quiz_form
fromedit_assessment_params
as a result. Note that the form would have already been read intoembedded_quiz_form_data
inupdate
confirmInstall
pages (they reference adoInstall
action that doesn't exist)deserialize
logic to utilizestart_at
date for all other dates if any of them are missingassessments_controller.rb#create
. Note that the front end code was commented out and removed in Github OAuth2 integration #1388 and Add user interface to upload config files, revamp file input fields #1883 respectively.Motivation and Context
Simplify the creation of assessments via scripting methods, especially when they are intended to be non-submittable.
Closes #1927
Also removes some unused fields to clean up the codebase.
How Has This Been Tested?
Propagate start_at
start_at
presentstart_at
, delete all other dates from assessmentyml
filestart_at
date to some date of your choicestart_at
dateyml
file to dates of your choiceyml
fileRegression tests
visible_at
,has_autograde_old
,has_scoreboard_old
,embedded_quiz_form
columns are not used anywhere elseTypes of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting