Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolab v2.11.1 #1976

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Autolab v2.11.1 #1976

merged 2 commits into from
Sep 5, 2023

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented Sep 5, 2023

Summary

Summary generated by Reviewpad on 05 Sep 23 19:12 UTC

This pull request includes two patches.

The first patch (PATCH 1/2) bumps the version to v2.11.1 in the config/application.rb file. It changes the value of config.site_version from "2.11.0" to "2.11.1".

The second patch (PATCH 2/2) disables the build check in the spec/rails_helper.rb file. It adds the --disable-build-check argument to the service configuration for the Selenium Chrome driver.

Overall, these patches update the version and disable the build check in the codebase. Nice work!

Description

  • Bump site version to v2.11.1
  • Add workaround for tests

Motivation and Context

Bump Autolab to v2.11.1, in view of changes and important bug fixes over summer.

Also adds a workaround for the ChromeDriver issue: https://twitter.com/jeremysmithco/status/1695089140373553266

How Has This Been Tested?

Run Autolab, observe that version number displayed is now v2.11.1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@reviewpad reviewpad bot requested a review from 20wildmanj September 5, 2023 00:26
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 5, 2023
@damianhxy damianhxy added this pull request to the merge queue Sep 5, 2023
Merged via the queue into master with commit d0757a4 Sep 5, 2023
6 checks passed
@damianhxy damianhxy deleted the v2.11.1 branch September 5, 2023 19:25
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 4, 2024
* Bump version to v2.11.1

* Disable build check

(cherry picked from commit d0757a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants