Override password reset email send when creating user

[jhs-panda]

Description

• commented out action that sends out password reset email when creating new user (regular or instructor)

Motivation and Context

With SMTP Config set up with single-sender (random personal account), the password reset email does not send successfully when creating a new user. Issue #2204
Since the SMTP Config cannot be changed, the password reset step is simply overridden.

How Has This Been Tested?

SMTP config in testing environment set up to be same as in Nightly (since issue occurring in Nightly).

Before:
Creating new user

Creating new course

Now, both functionalities work as intended.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve modifications to the user creation process in the UsersController and User model. Specifically, the functionality that automatically sends password reset instructions to newly created users has been commented out in both the create method of the UsersController and the instructor_create method of the User model. This alteration means that new users will no longer receive notifications to reset their passwords upon account creation.

Changes

File	Change Summary
app/controllers/users_controller.rb	Commented out the call to @user.send_reset_password_instructions in the create method.
app/models/user.rb	Commented out the call to user.send_reset_password_instructions in the instructor_create method.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UsersController
    participant UserModel

    User->>UsersController: Create account
    UsersController->>UserModel: Create user
    UserModel-->>UsersController: User created
    UsersController-->>User: Account created (no reset instructions sent)

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1133015 and 0aff723.

Files selected for processing (1)

• app/controllers/users_controller.rb (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/controllers/users_controller.rb

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[20wildmanj]

Could you change this so that instead of just commenting out the send password reset lines, there is code to catch the exception and flash the error?