Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make annotation UI more compact #2208

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Make annotation UI more compact #2208

merged 4 commits into from
Sep 20, 2024

Conversation

jlge
Copy link
Contributor

@jlge jlge commented Sep 15, 2024

Description

  • Remove extraneous padding and margins to reduce size of annotation UI
  • Annotation UI used to take up entire code block space on smaller laptop screens

Motivation and Context

Resolves #2202

How Has This Been Tested?

Go to speedgrader and add annotations, also view that adding multiple annotations to the same line + opening annotations in multiple lines looks fine

BEFORE:
image

AFTER:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

Walkthrough

Walkthrough

The changes involve modifications to the CSS and HTML of the annotation form to improve spacing and layout. The annotations.scss file has updated margin properties for specific classes, while the HTML file adds a new class to several <div> elements to ensure consistent spacing. These adjustments aim to create a more compact and visually appealing annotation UI.

Changes

Files Change Summary
app/assets/stylesheets/annotations.scss Adjusted margin properties for .row and .input-field classes to refine spacing.
app/views/submissions/_annotation_form.html.erb Added no-padding-bottom class to multiple <div> elements for consistent spacing.

Assessment against linked issues

Objective Addressed Explanation
Annotation UI takes up lots of space in Speedgrader (#2202)

Possibly related PRs


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 502e05b and d804d20.

Files selected for processing (2)
  • app/assets/stylesheets/annotations.scss (1 hunks)
  • app/views/submissions/_annotation_form.html.erb (2 hunks)
Files skipped from review due to trivial changes (1)
  • app/views/submissions/_annotation_form.html.erb
Additional comments not posted (2)
app/assets/stylesheets/annotations.scss (2)

252-254: LGTM!

Removing the default bottom margin from the .row class within the annotation form helps create a more compact vertical layout by reducing the space between rows.


263-266: LGTM!

Removing the bottom margin and adding a top margin to the .input-field class within the annotation form rows helps fine-tune the vertical spacing of input fields. The !important declaration ensures that this rule takes precedence over any conflicting styles.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jlge jlge requested review from a team and evanyeyeye and removed request for a team September 15, 2024 20:05
Copy link
Member

@evanyeyeye evanyeyeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlge jlge added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit e4714ba Sep 20, 2024
5 checks passed
@jlge jlge deleted the joanna-annotation-ui-changes branch September 20, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation UI takes up lots of space in Speedgrader
2 participants