Refactor the storage adapter tests to use a beforeEach hook
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
refactored-storage-adapter-tests
branch
from
62831d3
to
bb48906
Compare
|
cc @HerbCaudill as it seems you've worked on this file too 👍 |
kraenhansen
changed the title
beforeEach hookbeforeEach hook
HerbCaudill
requested changes
Sep 20, 2024
| adapter: StorageAdapterInterface | ||
| } | ||
|
|
||
| const it = test<AdapterTestContext> |
There was a problem hiding this comment.
small nitpick - I'd prefer
import { ..., it as _it } from "vitest"
...
const it = _it<AdapterTestContext>
|
Hi @kraenhansen. Thanks for working on this, and for introducing me to Vitest's test context API! I've leaned heavily on the (For anyone following along, it took me a while to find this in the docs - it's not referenced in the API reference, but it's documented in a standalone guide to Test Context.) |
HerbCaudill
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement tests of a storage which use async APIs, I need the
teardownfunction to be able to return a promise which gets awaited. I also took the liberty to refactor the tests a bit to use abeforeEachhook instead of callingsetupandteardownin each of the tests. This ensures theteardowngets called even if the test fails. In the current state, this isn't the case since something throwing in the test could prevent the call toteardown.