define block hash provider and default impl using frame_system #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β -----------------------------------------------------------------------------
Thank you for your Pull Request! π Please make sure it follows the contribution guidelines outlined in
this document and fill
out the sections below. Once you're ready to submit your PR for review, please
delete this section and leave only the text under the "Description" heading.
Description
Defines a Block Hash Provider for MMR pallet instead of using
frame_system::Pallet::block_hash
directlyDescribed here - Pallet-MMR should use custom
block_hash
getter instead of usingframe_system::block_hash
for non-canonicalised blocksΒ paritytech/polkadot-sdk#4062This add a new type to MMR config and with provided DefaultProvider, should not change anything on the logic wise.
Use Github semantic
linking
to address any open issues this PR relates to or closes.
Fixes paritytech#4062
β -----------------------------------------------------------------------------
The companion PR to upstream is approved and this commit will not necessary during the next upgrade, given upgrade contains the changes from the upstream PR.