Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define block hash provider and default impl using frame_system #14

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

vedhavyas
Copy link
Member

@vedhavyas vedhavyas commented Apr 11, 2024

βœ„ -----------------------------------------------------------------------------

Thank you for your Pull Request! πŸ™ Please make sure it follows the contribution guidelines outlined in
this document and fill
out the sections below. Once you're ready to submit your PR for review, please
delete this section and leave only the text under the "Description" heading.

Description

Use Github semantic
linking

to address any open issues this PR relates to or closes.

Fixes paritytech#4062
βœ„ -----------------------------------------------------------------------------

The companion PR to upstream is approved and this commit will not necessary during the next upgrade, given upgrade contains the changes from the upstream PR.

@vedhavyas vedhavyas requested a review from nazar-pc April 11, 2024 13:08
@vedhavyas
Copy link
Member Author

@nazar-pc seems like the rust-fmt check failed due to unrelated changes to this PR.
Is the incorrect formatting expected or should I fix it ?

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it compiles I'm okay with it. Can we wait for upstream PR to be merged first? Ideally we'd land the final version, but I understand we may need it sooner.

@vedhavyas
Copy link
Member Author

As long as it compiles I'm okay with it. Can we wait for upstream PR to be merged first? Ideally we'd land the final version, but I understand we may need it sooner.

That is fair. Its in the merge queue now. Will this one once upstream PR is merged into main

@vedhavyas vedhavyas merged commit b66c1c2 into subspace-v4 Apr 13, 2024
8 of 12 checks passed
@vedhavyas vedhavyas deleted the mmr_block_hash branch April 13, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants