Use CountedStorageMap instead of StorageValue to manage the Events in frame-system
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
StorageValuetheEventsis a single array in the state that keep growing as more extrinsic is executed and more events append to this array, which makes execution and storage root calculation slower and slower as allocation/copying/hashing this array takes more and more time.Similar to how we handle
Pendingstate in frontier (see polkadot-evm/frontier#1575), this PR useCountedStorageMapto manage the event and so each event will present as a single value in the state.NOTE: this PR also removes
#[pallet::whitelist_storage]for theEventsstate because it is only supported forStorageValue, so if we re-run the benchmark with this PR the extrinsic will be charged weight for outputting event.TODO: the
Eventsstate is cleared in the initialization of the next block, TBC we may need to add migration to ensure theStorageValueevent is properly clear after the runtime upgrade.