Optimize idle farmer memory usage #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time we've been caching table generators to optimize allocations. But given how much time it takes to generate a sector, with recent API changes I don't think we need to keep them between sectors.
One farmer confirmed on Discord that they don't see a meaningful difference in plotting performance with this change. Memory usage should also be comparable during plotting, but once plotting is over memory usage should drop significantly.
On one hand user still needs to have that memory available once replotting starts, but it is still beneficial do do since kernel will be able to use this memory for disk caching purposes for example while farming, which is much more helpful than just keeping memory allocated by farmer at all times.
Also resolves one TODO that I didn't want to address during earlier refactoring and now will not need to.
Code contributor checklist: