Fast sync improvements #2796
Merged
Fast sync improvements #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
revert-dsn-sync-changes
to
add-fast-sync-algorithm
May 28, 2024 10:03
shamil-gadelshin
approved these changes
May 28, 2024
| ) | ||
| .await?; | ||
| let mut blocks = VecDeque::from(blocks); | ||
| // Identify all segment headers that would need to be reconstructed in order to get first |
There was a problem hiding this comment.
It looks like overcomplicated code for the case when we need to get at most two segments. The previous version was much easier to follow.
| @@ -167,75 +144,101 @@ where | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Fix this implementation to actually follow the spec | |||
There was a problem hiding this comment.
Please, provide a brief algorithm description (without steps' descriptions you provided in the method body) and restore both notes: "reputation note" and "segment-block relative sizes that differ from blockchain parameters".
|
Ignore the comments. We discussed github glitches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fast sync to no assume anything about block size and makes the workflow more closely follow the spec.
It has a few inline comments that together with code structure and spec should be sufficient for understanding what is happening and why. I also improved some other explanations in comments.
Code contributor checklist: