Fast sync cleanup #2798
Merged
Fast sync cleanup #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
atomic-fast-sync-block-import
branch
from
7c76ff4
to
9abab27
Compare
nazar-pc
force-pushed
the
fast-sync-cleanup
branch
from
7b40165
to
aeb55ac
Compare
shamil-gadelshin
approved these changes
May 28, 2024
nazar-pc
force-pushed
the
atomic-fast-sync-block-import
branch
from
9abab27
to
1ad08d9
Compare
Base automatically changed from
atomic-fast-sync-block-import
to
add-fast-sync-algorithm
May 28, 2024 13:39
nazar-pc
force-pushed
the
fast-sync-cleanup
branch
from
aeb55ac
to
f247877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading through the code and found a few things that could be simplified. Unfortunately it was difficult to convince Rust to compile while maintaining
FastSyncstruct, so I removed it rather than fighting it for too long. DX around async in Rust could be much better.Ignore whitespace changes, changes are quite simple here.
Code contributor checklist: