Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sector plotting getting stuck #3041

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

nazar-pc
Copy link
Member

As discovered in smol-rs/async-lock#91 (comment) original polling attempt order is important and might cause issues if code was later serialized with a different order, which is exactly what was happening in process_plotting_result on farm-specific sectors_being_modified that was causing that farm to stop plotting and I believe even farming.

The solution is to move a piece of code into concurrent section so it can make progress.

I could have removed process_plotting_result by wrapping metadata_header in a Mutex and adding even more arguments to plot_single_sector, but that would result in out of order log messages for end users and didn't seem to be worth it.

Code contributor checklist:

@nazar-pc nazar-pc added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 2158aa4 Sep 20, 2024
9 checks passed
@nazar-pc nazar-pc deleted the fix-sector-plotting-getting-stuck branch September 20, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants