Update MMR sync. #3104
Closed
Update MMR sync. #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
requested review from
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
shamil-gadelshin
force-pushed
the
update-mmr-sync
branch
from
91ebc88
to
8ae468b
Compare
nazar-pc
reviewed
Oct 8, 2024
| @@ -5,7 +5,6 @@ use sc_client_api::{AuxStore, Backend, ProofProvider}; | |||
| use sc_consensus::{ | |||
| BlockImport, BlockImportParams, ForkChoiceStrategy, ImportedState, StateAction, StorageChanges, | |||
| }; | |||
| use sc_consensus_subspace::archiver::FINALIZATION_DEPTH_IN_SEGMENTS; | |||
There was a problem hiding this comment.
Please make this constant non-public again
There was a problem hiding this comment.
Ok. I'd consider moving the constant next time we make it public.
nazar-pc
approved these changes
Oct 9, 2024
1 task
|
Superseded by #3115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates MMR-sync. It removes the existing limitation of using
FINALIZATION_DEPTH_IN_SEGMENTSlag by calculating the proper temporary key by the block number and saving the MMR-node with a canon key in advance. This change allows us to snap sync to the confirmed domain block instead of to the block withinFINALIZATION_DEPTH_IN_SEGMENTSblocks lag and sync several segments after that.Code contributor checklist: