Refactor archiver public API to return ArchiveBlockOutcome #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
shamil-gadelshin,
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
1 task
nazar-pc
previously approved these changes
Oct 9, 2024
teor2345
dismissed stale reviews from shamil-gadelshin and nazar-pc
via
411a078
teor2345
force-pushed
the
archiver-public-api
branch
from
a1664c1
to
411a078
Compare
|
Done, with mass renames as requested. |
nazar-pc
approved these changes
Oct 9, 2024
nazar-pc
reviewed
Oct 12, 2024
| encoded_block, | ||
| block_object_mappings, | ||
| !sync_oracle.is_major_syncing(), | ||
| ) { | ||
| ); | ||
| send_object_mapping_notification( |
There was a problem hiding this comment.
Should skip this call if object mappings list is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares for PR #3100 by moving piece mappings from
NewArchivedSegmentinto a newArchiveBlockOutcomereturn type. It also updates the RPCs with a notification channel for these separate mappings.As part of this change, the archiver creates
GlobalObjects directly, which significantly simplifies the code.Code contributor checklist: