Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two key fixes here: Windows and linking.
Windows support is fixed (ignore whitespaces, the diff is very small), the solution is described in https://x.com/nazarpc/status/1844098745857667412
Linking was problematic after ROCm introduction because sppark seemed to always link
amdhip64
, even if only CUDA support was built (and I don't really see why), but dot-asm/sppark#2 fixed it alongside with DX improvements, so I pulled it into our fork at https://github.com/autonomys/sppark/tree/subspace-v1 and now it is good:I think the next simplification for CI would be to only build containers and then simply extract executables from then instead of building them on the host again.
Still thinking whether it would be a good idea to simply package into
zip
archive AMD libraries so user doesn't need to install their runtime through a custom repo manually, any opinion?Code contributor checklist: