Skip to content

Commit

Permalink
Add tests for MostSeen decrement bug
Browse files Browse the repository at this point in the history
This bug requires a specific set of circumstances to trigger
and become visible:
1. decrement a label that is non-zero but not first
2. repeat the decrement at least best_count()/2 times
3. increment that label
4. check the best count
  • Loading branch information
teor2345 authored Dec 5, 2024
1 parent 79d2e93 commit 0cf73c4
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions backend/common/src/most_seen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,5 +248,11 @@ mod test {
assert!(res.has_changed());
assert_eq!(a.best_count(), 2);
assert_eq!(*a.best(), "First"); // First is now ahead

a.remove(&"Third"); // 0, or 2 with bug #595
a.remove(&"Third"); // 0, or 4 with bug #595
a.insert(&"Third"); // 1, or 5 with bug #595
assert_eq!(a.best_count(), 2);
assert_eq!(*a.best(), "First"); // First is still ahead
}
}

0 comments on commit 0cf73c4

Please sign in to comment.