-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in progress #3
in progress #3
Conversation
@@ -0,0 +1,55 @@ | |||
FROM debian:jessie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the memcached image, Dockerfile, etc to https://github.com/autopilotpattern/memcached/tree/wip so it's more easily reused in other projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a good plan, I'll switch to building an image and working from that. That Dockerfile is mostly from the official memcached image, I just edited to add the containerbuddy stuff. I am going to go back to it and try and build it from the original image rather than copying the dockerfile the way I did here. I originally had a problem with the way they are using the memcached user, but I needed to do more work as root. Now I think I can switch back to root, install my needed things and then to back to memcached user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autopilotpattern/memcached#2 looks good. See my comments in Basecamp and the PR, and merge!
conformed helper script names organized files into /bin for consistency with recent projects others...
containerbuddy 1.3
# if their backends' onChange handlers are triggered simultaneously | ||
echo "******running onstart script*********" | ||
|
||
until [[ `curl -s ${CONSUL}:8500/v1/health/state/passing | grep mysql-primary` ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to use $CONSUL_HOST/v1/health/service/$SERVICE_NAME?passing
here?
and Containerbuddy 1.3.0
cleanup after renaming and Containerbuddy 1.3.0
{ | ||
"name": "wordpress", | ||
"port": 80, | ||
"publicIp": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publicIp
was deprecated in favor of specifying the interface priority list. See example in https://github.com/autopilotpattern/jenkins/blob/master/etc/containerbuddy.json#L15-L24
many changes from Casey's notes in: #3
now when nfs container is not present it: 1. umounts NFS mount on wordpress container 2. creates an mu-plugin that puts up and error_notice in wp-admin 3. disables media uploads for all user roles (media library button is removed)
DO NOT MERGE
This is a PR to track development in progress