numa: Fix the check of guest numa cell allaction #5368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hs0210
force-pushed
the
numa_check_nodes_sum
branch
from
d2067ea to
4fe1192
Compare
Could you paste test results for all cases? |
|
Hi @dzhengfy , for some cases, there's another issue which can be fixed by #5326 and avocado-framework/avocado-vt#3804 |
chloerh
reviewed
Jan 31, 2024
| for node_value in node_values.values(): | ||
| node_value_sum += int(node_value) | ||
| if node_value_sum <= 0: | ||
| numatest_obj.test.fail("Expect the sum of all node values is grater than 0, but found not") |
There was a problem hiding this comment.
Suggested change
| numatest_obj.test.fail("Expect the sum of all node values is grater than 0, but found not") | |
| numatest_obj.test.fail("Expect the sum of all node values is **greater** than 0, but found not") |
hs0210
force-pushed
the
numa_check_nodes_sum
branch
from
4fe1192 to
5fc3758
Compare
If the memory mode and memnode mode are not set, It is unpredictable on which host numa node a guest numa cell will be allocated. So all the host numa nodes should be checked. The current test only considers the case where the host has two numa nodes. This patch fixes this issue. Signed-off-by: Hu Shuai <[email protected]>
chloerh
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the memory mode and memnode mode are not set, It is unpredictable on which host numa node a guest numa cell will be allocated. So all the host numa nodes should be checked.
The current test only considers the case where the host has two numa nodes. This patch fixes this issue.
Before:
Result:
Debug log:
After:
Result:
Debug log: